TST: remove nose #15368
TST: remove nose #15368
Conversation
jreback
force-pushed
the
skip
branch
7 times, most recently
from
9ad1589 to
9049b5f
Compare
| else: | ||
| msg = "not using" | ||
| raise nose.SkipTest("{0} numexpr".format(msg)) | ||
| numexpr = pytest.importorskip('numexpr') |
There was a problem hiding this comment.
Didn't look into if this is important, but the importskip here is not fully equivalent with the above.
There was a problem hiding this comment.
yeah this is the only way to actually skip the entire module (well you can simply use a skipif on the classes, but this is cleaner).
There was a problem hiding this comment.
I meant that previously the test was also skipped if _USE_NUMPEXPR is false, now only when the import fails
There was a problem hiding this comment.
_USE_NUMEXPR == can import numexpr (and its not turned off)
| exc_failed_import : Exception, optional | ||
| Class of the exception to be thrown if import failed. | ||
| exc_failed_check : Exception, optional | ||
| Class of the exception to be thrown if version check failed. |
There was a problem hiding this comment.
also remove the actual arguments?
pandas/util/testing.py
Outdated
| package_check(exc_failed_import=SkipTest, | ||
| exc_failed_check=SkipTest, | ||
| *args, **kwargs) | ||
| package_check(*args, **kwargs) | ||
|
|
||
|
|
||
| def skip_if_no_package_deco(pkg_name, version=None, app='pandas'): |
There was a problem hiding this comment.
remove this whole function? It's nowhere used, and you removed its tests
There was a problem hiding this comment.
yeah I don't know how to actually test if a tests is actually skipped; in nose you can catch the SkipTest, but for pytest you would never do this.
There was a problem hiding this comment.
yeah, removing it. We have lots of testing cruft that pytest just does for free.
jreback
force-pushed
the
skip
branch
2 times, most recently
from
77af519 to
d0e61d7
Compare
TST: remove KnownFailure (unused), should be replaced by pytest.xfail anyhow TST: remove nose xref pandas-dev#15341
TST: raise nose.SkipTest -> pytest.skip TST: remove KnownFailure (unused), should be replaced by pytest.xfail anyhow xref pandas-dev#15341 Author: Jeff Reback <[email protected]> Closes pandas-dev#15368 from jreback/skip and squashes the following commits: afdb5f9 [Jeff Reback] TST: raise nose.SkipTest -> pytest.skip
TST: raise nose.SkipTest -> pytest.skip
TST: remove KnownFailure (unused), should be replaced by pytest.xfail anyhow
xref #15341